Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(editor): extract data view block #9452

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

Saul-Mirone
Copy link
Contributor

No description provided.

@Saul-Mirone Saul-Mirone marked this pull request as ready for review December 31, 2024 05:44
@Saul-Mirone Saul-Mirone requested a review from a team as a code owner December 31, 2024 05:44
Copy link
Contributor Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Saul-Mirone Saul-Mirone force-pushed the 12-31-refactor_editor_extract_data_view_block branch from e882049 to 2090a75 Compare December 31, 2024 05:57
Copy link

codecov bot commented Dec 31, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 51.58%. Comparing base (0f03c3f) to head (1e34ec8).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
...uite/affine/block-data-view/src/data-view-block.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9452      +/-   ##
==========================================
- Coverage   51.66%   51.58%   -0.09%     
==========================================
  Files        2152     2153       +1     
  Lines       97044    97031      -13     
  Branches    16210    16171      -39     
==========================================
- Hits        50138    50051      -87     
+ Misses      45587    45235     -352     
- Partials     1319     1745     +426     
Flag Coverage Δ
server-test 78.14% <ø> (ø)
unittest 31.04% <50.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Dec 31, 2024

Merge activity

@Saul-Mirone Saul-Mirone force-pushed the 12-31-refactor_editor_extract_data_view_block branch from 2090a75 to 1e34ec8 Compare December 31, 2024 06:15
@graphite-app graphite-app bot merged commit 1e34ec8 into canary Dec 31, 2024
61 checks passed
@graphite-app graphite-app bot deleted the 12-31-refactor_editor_extract_data_view_block branch December 31, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants